Additional Unit Tests Column Logic #1348
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Only the
get_nested_column_data_types
method indbt/adapters/bigquery/column.py
has unit tests defined. This method relies on other methods to produce its output. These other methods operate recursively and can be difficult to follow for the range of possible inputs (as I found when investigating #1278). Adding more unit tests to ensure the integrity of these recursive methods would provide developers with a lot more confidence when making changes.Solution
This PR adds many unit tests for the recursive
_update_nested_column_data_types
method. These will help ensure the integrity of column-related logic, particularly more complex logic around the handling of nested columns.Checklist